JuliaLang / JuliaLang/LinearAlgebra.jl

QR should check size of b in ldiv!(A::QR, b)

Open
#616 4 comments 0 reactions 1 assignee Claimed by @andreasnoack View on GitHub
bug
Dominant language
Julia
Stars
77
Forks
65
Avg merge
3d 23h
Merged PRs (30d)
10

Description

`QRCompactWY` checks dimensions in `ldiv!`. But the type `QR` as constructed by `LinearAlgebra.qrfactUnblocked!` does not:

```julia
julia> A = randn(5,3);

julia> ldiv!(qr(A), randn(6))
ERROR: DimensionMismatch("first dimensions of C, 6, and V, 5 must match")
Stacktrace:
[1] gemqrt!(::Char, ::Char, ::Array{Float64,2}, ::Array{Float64,2}, ::Array{Float64,1}) at /Users/solver/Projects/julia-1.1/usr/share/julia/stdlib/v1.1/LinearAlgebra/src/lapack.jl:2842
[2] lmul! at /Users/solver/Projects/julia-1.1/usr/share/julia/stdlib/v1.1/LinearAlgebra/src/qr.jl:582 [inlined]
[3] ldiv!(::LinearAlgebra.QRCompactWY{Float64,Array{Float64,2}}, ::Array{Float64,1}) at /Users/solver/Projects/julia-1.1/usr/share/julia/stdlib/v1.1/LinearAlgebra/src/qr.jl:740
[4] top-level scope at none:0

julia> ldiv!(LinearAlgebra.qrfactUnblocked!(A), randn(6))
6-element Array{Float64,1}:
1.0387393123745625
-0.5527232940083197
1.6018083989805358
-0.07834802309401183
0.021939022643475848
0.69631987602793
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.