JuliaLang / JuliaLang/JuliaSyntax.jl

Split up syntax.jl tests in Base so that JuliaSyntax can test the non-controversial parts.

Open
#533 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Julia
Stars
293
Forks
50
PR merge metrics
No merged PRs in 30d

Description

Right now, the `syntax.jl` tests are skipped (https://github.com/JuliaLang/JuliaSyntax.jl/blob/2e965a159dd9f87d216d2d50ecbd2ed4f9af2c5a/test/parse_packages.jl#L41-L46). However, this causes us to sometimes regress, see e.g. https://github.com/JuliaLang/julia/pull/57188/files#diff-266674e240feff7742a800c1c360befe28cd7a20f49dada34fef94a122acd90b where the test got changed and then caused regressions https://github.com/JuliaLang/julia/issues/57223.

It would probably be a good idea to split up `syntax.jl` into a "controversial" part which is not tested by JuliaSyntax and a standard part which does get tested. Ideally, as time moves on the controversial part is shrunk.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.