JuliaLang / JuliaLang/Distributed.jl

Test failed when running with MMTk

Open
#132 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Julia
Stars
55
Forks
19
PR merge metrics
No merged PRs in 30d

Description

I just wanted to note that a test failed when running our CI when building Julia with MMTk here. I had a quick look at the code and my guess is that this line:

    testcode = setupcode * """
    for w in workers()
        @test remotecall_fetch(depot_path, w)          == DEPOT_PATH
        @test remotecall_fetch(load_path, w)           == LOAD_PATH
        @test remotecall_fetch(Base.load_path, w)      == Base.load_path()
        @test remotecall_fetch(active_project, w)      == Base.ACTIVE_PROJECT[]
        @test remotecall_fetch(Base.active_project, w) == Base.active_project()
    end
    """

Should be changed into:

    testcode = setupcode * """
    for w in workers()
        @test remotecall_fetch(depot_path, w)          == reverse_first_two(DEPOT_PATH)
        @test remotecall_fetch(load_path, w)           == LOAD_PATH
        @test remotecall_fetch(Base.load_path, w)      == Base.load_path()
        @test remotecall_fetch(active_project, w)      == Base.ACTIVE_PROJECT[]
        @test remotecall_fetch(Base.active_project, w) == Base.active_project()
    end
    """

But honestly I know nothing about this code so I'm not sure if that makes sense. If it does, I'm happy to open a PR to fix it. Either way, I feel like I should report it here though in case this was a mistake on your end rather than something from our CI.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/distributed_exec.jl around line 1879 and inspect the linked MMTk CI failure. Understand why the depot_path comparison differs under MMTk and verify whether reverse_first_two(DEPOT_PATH) is the intended expectation. Done means the test's behavior is confirmed and the relevant CI run passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
distributed-systems, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.