JuliaImages / JuliaImages/ImageFiltering.jl

Wrong LoG scale normalization in `blob_LoG`

Open
#278 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
104
Forks
52
PR merge metrics
No merged PRs in 30d

Description

The correct scale normalization for LoG should be -σ^2 instead of in the multiLoG function called by blob_LoG.

In addition, the docstring of BlobLoG says:

radius is equal to σ√2

but

radius is equal to σ√N for a N-dimensional image

is more accurate.

This error is easy to fix and I can handle it on my own (please note that this will be my first PR so any guidance is much appreciated!).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the multiLoG function called by blob_LoG and the BlobLoG docstring. Check the current normalization and radius wording against the issue description, then review nearby tests or examples for expected behavior. Done means both corrections are reflected and the relevant existing checks still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
computer-vision
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.