JuliaImages / JuliaImages/ImageFiltering.jl
`findlocalmaxima` fail to handle repeated peaks
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 104
- Forks
- 52
- PR merge metrics
- No merged PRs in 30d
Description
julia> findlocalmaxima([1 2 3 2 1])
1-element Vector{CartesianIndex{2}}:
CartesianIndex(1, 3)
julia> findlocalmaxima([1 2 3 3 1])
CartesianIndex{2}[]
I'm not sure whether it is a bug or I need to handle this case outside findlocalmaxia
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the implementation of findlocalmaxima and any existing tests, then reproduce the two Julia examples from the issue. Read how repeated or plateau peaks are currently handled and establish the expected result for [1 2 3 3 1]. Done means the behavior is specified by a regression test and the function handles the repeated peak consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100