JuliaImages / JuliaImages/ImageFiltering.jl

introduce a `findall` version of `mapwindow`

Open
#224 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
104
Forks
52
PR merge metrics
No merged PRs in 30d

Description

Originally posted in https://github.com/JuliaImages/ImageFiltering.jl/pull/223#pullrequestreview-744624172

We have mapwindow that applies function f on every local patch of an image, which can be seen as the image version of map. We don't have the window version of findall that applies f to each local patch, and return coordinates such that f(window_of_p) == true.

Why we need this? We can currently do this by returning a dense Bool matrix from mapwindow and then call findall, but this would usually be unnecessary and not as performant as the manually written for-loops. For example, the benchmark in https://github.com/JuliaImages/ImageSegmentation.jl/pull/72#issuecomment-910135541

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing mapwindow implementation and the discussion in pull request #223. Compare the proposed windowed findall behavior with the benchmark linked from ImageSegmentation.jl pull request #72. Done means applying f to local patches and returning coordinates for true results without requiring a dense Boolean matrix.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
computer-vision
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.