JuliaImages / JuliaImages/ImageCore.jl
rawview: unnecessary MappedArray wrapper on N0f8 arrays
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 28
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
Is there any reason why we use mappedarray rather than plain reinterpret here?
This adds a few performance overheads to ImageMorphology https://github.com/JuliaImages/ImageMorphology.jl/issues/103 because pointer of MappedArray is an invalid concept.
I notice this is written 4-6 years ago, is it because reinterpret for array type was not yet available?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/ImageCore.jl around line 124 and compare the current mappedarray use with the proposed plain reinterpret behavior for N0f8 arrays. Review the referenced ImageMorphology issue for the pointer and performance impact; the issue is resolved when the compatibility rationale and whether the wrapper can be removed are established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100