JuliaImages / JuliaImages/ImageBase.jl
Some `@test_broken` now seem to pass on 1.10
Open
@timholy is already working on this.
Since Jul 31, 2023.
- Dominant language
- Julia
- Stars
- 4
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
minfinite, maxfinite, maxabsfinite: Error During Test at /home/pkgeval/.julia/packages/ImageBase/z0ixH/test/statistics.jl:104
Expression evaluated to non-Boolean
Expression: #= /home/pkgeval/.julia/packages/ImageBase/z0ixH/test/statistics.jl:104 =# @inferred maximum_finite(A; dims = 1)
Value: N0f8[0.976N0f8 0.957N0f8 … 0.796N0f8 0.529N0f8]
minfinite, maxfinite, maxabsfinite: Error During Test at /home/pkgeval/.julia/packages/ImageBase/z0ixH/test/statistics.jl:105
Expression evaluated to non-Boolean
Expression: #= /home/pkgeval/.julia/packages/ImageBase/z0ixH/test/statistics.jl:105 =# @inferred minimum_finite(A; dims = 1)
Value: N0f8[0.059N0f8 0.267N0f8 … 0.435N0f8 0.09N0f8]
...
etc. I guess this means that the @inferred macro now goes through but then the test is written in a way where it doesn't handle that gracefully.
cc @timholy
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.