JuliaIO / JuliaIO/TranscodingStreams.jl

Safety and usability improvements in `copydata!`

Open
#165 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
90
Forks
25
PR merge metrics
No merged PRs in 30d

Description

As mentioned in: https://github.com/JuliaIO/TranscodingStreams.jl/pull/164

There are two implementations of copydata! used in Base.unsafe_read and Base.readuntil. There may be a lurking bug with unclear ownership as well (regarding GC.@preserve). This scenario should likely be cleaned up a bit to mitigate bugs.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the two copydata! implementations in src/noop.jl near Base.unsafe_read and src/stream.jl near Base.readuntil, then read the context from PR #164. Trace the ownership and GC.@preserve concerns across both paths; done means the duplicated scenario is cleaned up and ownership is clear enough to mitigate the suspected bugs.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.