Make MatlabStructArray an AbstractDict
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 293
- Forks
- 79
- PR merge metrics
- No merged PRs in 30d
Description
For better consistency with MatlabClassObject and other structs/objects, and backwards compatibility with previous MAT versions, we could consider making the MatlabStructArray <: AbstractDict. I think most dict interfaces are already implemented, like key-value iteration, getindex and setindex.
I'm consider what the implications are here:
- it's actually an
AbstractDict{String, Array{Any,N}}, notAbstractDict{String,Any}like all our other types - could we still consider it an
AbstractArray, an interface I still want to implement someday so thats[1,2]returns a Dict - we should add all abstractdict interfaces (what is the abstractdict interface anyway?)
- need to add keys/names
s["new"] = arr - delete keys:
delete!(s, "old") - Unless it's a class array, then it should be immutable, since the class properties are fixed?
- need to add keys/names
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the MatlabStructArray implementation and comparing it with MatlabClassObject and the other struct/object types. Review Julia's AbstractDict interface alongside the existing key-value iteration, getindex, and setindex methods, then resolve the AbstractArray, class-array immutability, and type-parameter questions. Done means the supported interfaces and compatibility implications are clearly decided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100