Support for file extensions using uppercase letters
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 228
- Forks
- 81
- Avg merge
- 1d 29m
- Merged PRs (30d)
- 1
Description
I'm running into problems when trying to read Excel files with uppercase extensions:
filename = "test.XLS"
df = DataFrame(load(filename, "Sheet1"))
Leads to
ERROR: NoDecodeDelegateForThisImageFormat `XLS' @ error/constitute.c/ReadImage/560
When I rename the file to test.xls everything works fine.
I'm also able to get things to work by changing the code here:
https://github.com/JuliaIO/FileIO.jl/blob/9e6d49d57aaad3945a91b57f18ea5f45b73ef7e0/src/registry.jl#L35
to:
add_format(format"Excel", (), [".xls", ".xlsx", ".XLS", ".XLSX"], [:ExcelFiles])
I see that a few formats have definitions for upper and lowercase variants of the file extensions, although it seems like it would be more ideal to just convert the extension string to lower case when trying to figure out which format the file is in.
This might be related to #236
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/registry.jl around the add_format definition linked in the issue, then reproduce loading test.XLS with the shown Julia example. Check the related discussion in #236 for context. Done means uppercase .XLS and .XLSX extensions are recognized consistently with lowercase variants.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100