JuliaGraphs / JuliaGraphs/Graphs.jl
Squash implementation missing
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 538
- Forks
- 128
- Avg merge
- 10h 25m
- Merged PRs (30d)
- 2
Description
Some squash implementations are missing:
Warning: squash(::AbstractGraph) is deprecated in favor of methods that specialize on the graph type.
│ caller = macro expansion at core.jl:112 [inlined]
└ @ Core ~/work/Graphs.jl/Graphs.jl/test/core.jl:112
Just needs the specialisations function checking for which types are missing. Happy to take.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in test/core.jl around line 112, where the deprecation warning is shown, and inspect the existing squash specializations and graph types used by the tests. Determine which types still fall back to squash(::AbstractGraph), add the missing specializations, and run the relevant core tests to confirm the warning is gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 42/100