JuliaGraphs / JuliaGraphs/Graphs.jl
Indexability of `vertices` and `neighbors`
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 538
- Forks
- 128
- Avg merge
- 10h 25m
- Merged PRs (30d)
- 2
Description
In the PRs done by @simonschoelly to test on generic graphs, he frequently ran into trouble because collections like vertices(g) or neighbors(g, v) were not indexable. This explains the appearance of the function collect_if_not_vector throughout the code.
@etiennedeg what will this behavior look like in GraphsBase?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the implementations and call sites for vertices(g), neighbors(g, v), and collect_if_not_vector, then review the referenced generic-graph PRs. Clarify the intended indexability contract for GraphsBase with maintainers; done means the behavior is decided and consistently reflected in the affected graph APIs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100