JuliaGraphs / JuliaGraphs/Graphs.jl

`transitiveclosure` only works on `SimpleDiGraph`s

Open
#245 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Julia
Stars
538
Forks
128
Avg merge
10h 25m
Merged PRs (30d)
2

Description

The guilty lines of code:

https://github.com/JuliaGraphs/Graphs.jl/blob/53cb58152a19ca62fa01439300948c30035dca6a/src/digraph/transitivity.jl#L105-L108

Is there a reason why:

  • the function dispatches on a concrete graph type
  • it doesn't support undirected graphs?

First spotted by https://github.com/JuliaGraphs/SimpleWeightedGraphs.jl/issues/10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/digraph/transitivity.jl at lines 105-108 and inspect the transitiveclosure method's dispatch and related graph interfaces. Compare the behavior for SimpleDiGraph and undirected or other graph types, then add focused coverage showing which graph types should be supported and verify the full graph test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.