JuliaGraphs / JuliaGraphs/GraphPlot.jl

Question: What is the point of `NODELABELSIZE` and other capitalized kwargs?

Open
#177 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
213
Forks
62
PR merge metrics
No merged PRs in 30d

Description

I see that these are used for converting from relative sizes to absolute sizes. Why not just use absolute sizes in the first place? I think having two keyargs with the same name but different capitalization is just redundant and sometimes confusing.

I can put together a PR that switches to just absolute sizes if desired.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Search for NODELABELSIZE and the corresponding lowercase keyword arguments, then inspect how relative sizes are converted to absolute sizes and where both forms are documented or tested. Done requires a maintainer decision on the keyword API and agreement on the affected behavior and compatibility expectations.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data-visualization
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.