JuliaGraphs / JuliaGraphs/GraphNeuralNetworks.jl
Mooncake on CUDA issue tracker
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 308
- Forks
- 74
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 2
Description
I ran Mooncake on GPU where the test sites for CPU were enabled (Mooncake 0.5.41, CUDA.jl 6.2.1, Flux 0.16.10, Julia 1.12.5).
CPU is fully green, but many fail on GPU. Here are my findings:
Already works on GPU (COO storage): GraphConv, SAGEConv, GINConv, EdgeConv, NNConv, ResGatedGraphConv, CGConv, MEGNetConv, GlobalPool, GlobalAttentionPool, GCNConv with add_self_loops=false, and all the propagate fast paths (copy_xj with +/mean, e_mul_xj, w_mul_xj). The rules in GNNlibMooncakeExt.
Zygote uses ChainRules for non-differentiable functions, Mooncake doesn't, so it the hits GPU code it can't differentiate:
add_self_loopsfor COO doesnodes = convert(typeof(s), [1:n;]), i.e. builds a CPU vector and copies it to the GPU. That lands on a CPU→GPUunsafe_copyto!containing try/catch, which Mooncake can't trace (its cross-device copy rule only covers float arrays, and here the destination is an integer index array). It affects all layers with self loops: GCNConv (default), GATConv, GATv2Conv, TransformerConv, AGNNConv, SGConv, TAGConv, TGCN.- On
:densegraphs,edge_index/to_coocall_findnz_idx, i.e.findallon aCuArray{Bool}(no Mooncake rule), and right after thatv = A[nz]indexes with a vector ofCartesianIndex(also no rule). This kills every layer on dense storage.
We can add GNNGraphs/ext/GNNGraphsMooncakeExt.jl (Mooncake as weakdep) giving Mooncake the same semantics the ChainRules markers give Zygote:
Mooncake.@zero_derivative Mooncake.DefaultCtx Tuple{typeof(add_self_loops), GNNGraph}
Mooncake.@zero_derivative Mooncake.DefaultCtx Tuple{typeof(GNNGraphs._findnz_idx), Any}
Mooncake.@zero_derivative Mooncake.DefaultCtx Tuple{typeof(to_coo), GNNGraphs.ADJMAT_T}
Mooncake.@zero_derivative Mooncake.DefaultCtx Tuple{typeof(Core.kwcall), NamedTuple, typeof(to_coo), GNNGraphs.ADJMAT_T}
The Core.kwcall rule is required because all in-repo call sites call to_coo with keyword arguments. I validated all of this by defining the rules via type piracy in a test script: with them in place, GCNConv (coo and dense), EdgeConv/dense, ResGatedGraphConv/dense, SGConv, AGNNConv, GMMConv and GatedGraphConv pass on GPU with gradients matching Zygote to ~1e-7.
Two caveats worth recording in the ext:
add_self_loops: same caveat as the existing@non_differentiablein transform.jl (the graph carries feature arrays; fine in practice since layers takexexplicitly).to_coo: Zygote only skips_findnz_idxand still differentiatesA[nz], so it deliversdAfor weighted dense adjacencies. A zero-derivativeto_coodrops that under Mooncake. If Mooncake gains a CartesianIndex getindex rule upstream (item 4 below), we can drop theto_coorules and keep full parity.
Upstream Mooncake.jl gaps found (I think I can open some issues on Mooncake regarding this):
- Correctness bug: broadcasts over non-contiguous
SubArrays of CuArrays silently drop gradients. This is why GatedGraphConv returns wrong gradients with no error on GPU. Flux's GRUCell slices its gates withchunk(Wi*x, 3, dims=1). - No kwcall rule for
sum(x::CuArray; dims). It breaks GMMConv and other attention score computation. - Cross-device
unsafe_copyto!rule covers float destinations only, not integer. - No
getindex(::CuArray, ::Vector{CartesianIndex})rule. CuMatrix + CuMatrix→cuBLAS.geam!has no rule (CuReftangent type missing).- No
repeat(::CuArray, ...)rule (hits TGCNCell'srepeat(h, 1, g.num_nodes)). task_local_storage()IdDict fdata mismatch, reached through CUDA's default RNG bydropout.
I will work on these once it gets green flag.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing non-differentiable marker in transform.jl and the proposed GNNGraphs/ext/GNNGraphsMooncakeExt.jl integration. Reproduce the Mooncake GPU failures described for COO and dense graphs, then validate the extension against the listed layers with gradients compared to Zygote. Done means the in-repository Mooncake extension is scoped and its supported cases pass; the separate upstream gaps remain distinct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100