JuliaGeometry / JuliaGeometry/Rotations.jl

Prettier printing for RotABC

Open
#292 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
188
Forks
45
PR merge metrics
No merged PRs in 30d

Description

The current printing of a RotXYZ is not the best:

julia> RotXYZ(deg2rad.((10, 20, 30))...)
3×3 RotXYZ{Float64} with indices SOneTo(3)×SOneTo(3)(0.174533, 0.349066, 0.523599):
  0.813798  -0.469846   0.34202
  0.543838   0.823173  -0.163176
 -0.204874   0.318796   0.925417

My concrete issue is the first line: 3×3 RotXYZ{Float64} with indices SOneTo(3)×SOneTo(3)(0.174533, 0.349066, 0.523599):. I find it provides too much information, and the interesting information (the angles) are not clearly angles. I would suggest something along the lines of:

julia> RotXYZ(deg2rad.((10, 20, 30))...)
3×3 RotXYZ{Float64} with angles in radians = (0.174533, 0.349066, 0.523599):
  0.813798  -0.469846   0.34202
  0.543838   0.823173  -0.163176
 -0.204874   0.318796   0.925417

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the RotXYZ display or printing entry point and any tests covering its REPL output. Update the first line to identify the values as angles in radians while retaining the displayed rotation matrix, then verify the example output.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
computer-graphics
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.