JuliaGeometry / JuliaGeometry/Rotations.jl

Change the order of `QuatRotation` from `(w,x,y,z)` to `(x,y,z,w)`

Open
#210 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

v2.0.0
Dominant language
Julia
Stars
188
Forks
45
PR merge metrics
No merged PRs in 30d

Description

To be able to set the orientation of an object in a 3D scene of Makie.jl I use the following code:

    q0        = Rotations.params(QuatRotation(state.orient))     # returns an SVector in the order w,x,y,z
    quat[]    = Quaternionf0(q0[2], q0[3], q0[4], q0[1])         # the constructor expects the order x,y,z,w

This looks overly complicated to me. Can't this be done easier?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the named QuatRotation and Rotations.params APIs, then compare their parameter order with the Quaternionf0 constructor used in the Makie example. Review the 12-comment discussion for the intended compatibility and API outcome. Done means the agreed quaternion ordering is implemented consistently and the example no longer needs manual reordering.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
computer-graphics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.