JuliaGeometry / JuliaGeometry/GeometryBasics.jl
Why are `Multi{Polygon,Linestring,...} <: AbstractVector` and not `<: AbstractGeometry`
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 215
- Forks
- 64
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 2
Description
What is the benefit of them being AbstractVectors?
In AlgebraOfGraphics we would like to support all shapes that are plottable. We would like to just implement methods for AbstractGeometry. Instead we have to define methods for Multi* types separately.
https://github.com/JuliaPlots/AlgebraOfGraphics.jl/pull/80
related to #70
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing AlgebraOfGraphics.jl PR #80 and GeometryBasics.jl issue #70, then inspect how the Multi* types relate to AbstractVector and AbstractGeometry. Determine whether the hierarchy should change and document the benefits or trade-offs; done means a decided design that lets AlgebraOfGraphics handle plottable shapes consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100