JuliaGeometry / JuliaGeometry/GeometryBasics.jl

Define length for cylinders

Open
#265 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
215
Forks
64
Avg merge
3d 18h
Merged PRs (30d)
2

Description

Many basic shapes do not have an unambiguous length. However, cylinders are kinds of line segments with an additional radius or thickness, and since line segments have a rather unambiguous length, it would make sense to add a method Base.length(::GeometryBasics.Cylinder), defined as the norm of the vector LinearAlgebra.norm(c.extermity - c.origin) for a c::GeometryBasics.Cylinder.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the requested Base.length(::GeometryBasics.Cylinder) entry point and the Cylinder type in GeometryBasics. Implement the specified norm of c.extermity - c.origin, then run the repository tests and verify that the returned length matches the cylinder's axis segment.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
computer-graphics
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.