JuliaGeometry / JuliaGeometry/GeometryBasics.jl

Parametric type of `Mesh` restricted to `Real`

Open
#261 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
215
Forks
64
Avg merge
3d 18h
Merged PRs (30d)
2

Description

Right now, the parametric type T of GeometryBasics.Mesh is restricted to Real:
https://github.com/JuliaGeometry/GeometryBasics.jl/blob/caa6c89f9dabe2512fb1ab8095d75aff9f9e4ea3/src/basic_types.jl#L503-L505

It used to be restricted to Number initially, but this was changed in #219.
I see that it was first changed from Number to Real in https://github.com/JuliaGeometry/GeometryBasics.jl/pull/219/commits/b08b6f9179c02e6406757cf3cf4984e1b2514d7b, adding a TODO to check if it should be Number. The TODO was then finally removed in https://github.com/JuliaGeometry/GeometryBasics.jl/pull/219/commits/a0a6a84c4e75ffab5ed2070568465bd1aa9c6bc0.

Is there any reason why T was restricted to Real?
The reason I'm asking is because I am playing around with Unitful and the current implementation does not allow for T in Mesh to be a Unitful.Quantity <: Number, for example.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/basic_types.jl at the Mesh definition and review the linked #219 changes that restricted its parametric type from Number to Real. Investigate whether Unitful.Quantity should be accepted and what consequences that has for Mesh; done requires a decided compatibility direction and corresponding validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.