JuliaGeometry / JuliaGeometry/GeometryBasics.jl

FaceView Documentation, MethodError: no method matching FaceView(::Vector{Point{3, Float32}}, ::Vector{TriangleFace})

Open
#202 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
215
Forks
64
Avg merge
3d 18h
Merged PRs (30d)
2

Description

The following example is included in the documentation for FaceView, but no longer functions.

x = FaceView(rand(Point3f, 10), TriangleFace[(1, 2, 3), (2, 4, 5), ...])
x[1] isa Triangle == true
x isa AbstractVector{<: Triangle} == true
# This means we can use it as a mesh:
Mesh(x) # should just work!
# Can also be used for Points:

linestring = FaceView(points, LineFace[...])
Polygon(linestring)

https://github.com/JuliaGeometry/GeometryBasics.jl/blob/89b857e33e8c33d1304d1630836b4d0b466869ef/src/viewtypes.jl#L105-L122

julia> using GeometryBasics

julia> x = FaceView(rand(Point3f, 10), TriangleFace[(1, 2, 3), (2, 4, 5)])
ERROR: MethodError: no method matching FaceView(::Vector{Point{3, Float32}}, ::Vector{TriangleFace})

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failing FaceView example with Julia, then inspect src/viewtypes.jl around lines 105-122 and the current FaceView API. Update the documentation example so it uses a working form, and verify the shown Mesh and Polygon examples no longer produce the reported method error.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.