JuliaGeometry / JuliaGeometry/Contour.jl
When no contours are found, `contour` should not return a ContourLevel of 0 lines?
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 46
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Description
The hierarchy of types/structs you have makes it possible to have a ContourLevel at an isovalue but containing 0 lines, which doesn't make sense. Then, the lack of error means this simple function definition
gives you a ContourCollection of 1 ContourLevel, but that contour has no lines. Can this interface be improved?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/Contour.jl line 94 and inspect the contour entry point and the ContourCollection/ContourLevel types. Determine the intended result when no contour lines are found; the work is done when that case no longer produces a ContourLevel containing zero lines, with behavior covered by the relevant tests if they exist.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100