JuliaGaussianProcesses / JuliaGaussianProcesses/KernelFunctions.jl
iskroncompatible
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 275
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Description
iskroncompatibleappears to be incorrectly implemented in a couple of places. For example, I don't believe that anExponentialKernelshould not be marked as compatible, or have I misunderstood something?- Do we really want to try and do this with a flag method? Would be not be better off introducing a
RectilinearGridinput type (that is a subtype ofAbstractVector) and then using dispatch to figure out whether it's correct to return aKroneckerMatrixwhenkernelmatrixis called?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the implementations and uses of iskroncompatible, then inspect how kernelmatrix decides whether to return a KroneckerMatrix. Resolve whether ExponentialKernel is compatible and determine whether dispatch on a RectilinearGrid should replace the flag method; done means the compatibility behavior and API direction are settled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100