JuliaGaussianProcesses / JuliaGaussianProcesses/KernelFunctions.jl
Define `isequal` and `==` more widely between `Kernel`s
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 275
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Description
It would be nice to define isequal and/or == as widely as possible between Kernels and Transforms. At the moment some basic cases seem to be missing, such as
julia> using KernelFunctions
julia> a = 2*WhiteKernel()
White Kernel
- σ² = 2
julia> b = 2*WhiteKernel()
White Kernel
- σ² = 2
julia> a == b
false
julia> isequal(a, b)
false
I'm not clear exactly when isequal/== both should be extended (and if hash is also needed), but would be happy to work on an PR that starts to improve this if there's a clear way forward.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing how equality is currently handled for Kernels and Transforms, then compare the behavior of == and isequal for equivalent objects such as two 2*WhiteKernel() values. Decide which cases should be supported and whether hash must follow those semantics; done means the intended behavior is documented by tests, including the basic example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100