JuliaGaussianProcesses / JuliaGaussianProcesses/KernelFunctions.jl
Explaining ColVecs vs RowVecs in MO helpers
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 275
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Description
This is more related to the last MR, but should we be providing any explanation as to why Y being a ColVecs or RowVecs affects the output? It looks like it is just being used as an indicator here really, but some people seeing this might think theres is some intrinsic connection between ColVecs and MOInputIsotopicByFeatures (unless there is one that I am missing!)
Originally posted by @thomasgudjonwright in https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/pull/353#discussion_r684975708
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the MO helpers that use Y with ColVecs or RowVecs, and review the context in pull request #353. Clarify in the relevant documentation or helper explanation whether the vector orientation has an intrinsic connection to MOInputIsotopicByFeatures or is only an indicator, then confirm the wording matches the implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100