JuliaGaussianProcesses / JuliaGaussianProcesses/KernelFunctions.jl
show
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 275
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Description
i don't think we want to overload 2-arg show here, only the 3-arg plain-text method below.
The reason is that we probably want repr to return parseable code that recreates a NaiveLMMMOKernel (other kernels in this package seem to have overloaded 2-arg show to have non-parseable "pretty printing" output, which also seems a mistake to me)
And 3-arg show is what gets used in the repl, so probably all you want for pretty-printing.
(But my opinion here might be at adds with the currect practices of the package, so we can move this discussion to an issue if that's better)
Originally posted by @nickrobinson251 in https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/pull/304#discussion_r655375183
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the show/repr implementations for NaiveLMMMOKernel and the discussion in PR #304. Compare the 2-argument and 3-argument methods with related kernels, then confirm that pretty-printing remains available while repr produces parseable code; the issue does not name a test file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100