JuliaGaussianProcesses / JuliaGaussianProcesses/KernelFunctions.jl
Unnecessary collect?
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 275
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Description
#159 has thrown up a couple of issues. In particular, to get the tests to pass I had to modify this line with an additional call to collect.
Would be good to get to the bottom of what's going on here for performance reasons.
If you're interested in tackling this, the simplest way to get started is to run the tests locally having reverted this line to it's former collect-free state.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the line changed in PR #159 and revert it to the former collect-free state, as described in the issue. Run the tests locally, investigate why the additional collect is needed, and compare the performance implications before determining whether it can be removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning, performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100