JuliaGPU / JuliaGPU/AMDGPU.jl

KA tests trigger assertion if julia is built with them

Open
#546 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
344
Forks
79
Avg merge
2d 19h
Merged PRs (30d)
25

Description

/home/gabrielbaraldi/julia4/src/llvm-late-gc-lowering.cpp:1029: void NoteDef(State&, BBState&, int, const std::vector<int, std::allocator<int> >&): Assertion `Num >= 0' failed.

[132189] signal (6.-6): Aborted
in expression starting at /home/gabrielbaraldi/.julia/dev/AMDGPU/test/ka_tests.jl:17
pthread_kill at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
raise at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
abort at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x7f9808c2871a)
__assert_fail at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
NoteDef at /home/gabrielbaraldi/julia4/src/llvm-late-gc-lowering.cpp:1029
MaybeNoteDef at /home/gabrielbaraldi/julia4/src/llvm-late-gc-lowering.cpp:1049
LocalScan at /home/gabrielbaraldi/julia4/src/llvm-late-gc-lowering.cpp:1756
runOnFunction at /home/gabrielbaraldi/julia4/src/llvm-late-gc-lowering.cpp:2758
run at /home/gabrielbaraldi/julia4/src/llvm-late-gc-lowering.cpp:2786
run at /home/gabrielbaraldi/julia4/usr/include/llvm/IR/PassManagerInternal.h:88
_ZN4llvm11PassManagerINS_8FunctionENS_15AnalysisManagerIS1_JEEEJEE3runERS1_RS3_ at /home/gabrielbaraldi/julia4/usr/bin/../lib/libLLVM-15jl.so (unknown line)
run at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/PassManagerInternal.h:88
_ZN4llvm27ModuleToFunctionPassAdaptor3runERNS_6ModuleERNS_15AnalysisManagerIS1_JEEE at /home/gabrielbaraldi/julia4/usr/bin/../lib/libLLVM-15jl.so (unknown line)
run at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/PassManagerInternal.h:88
LLVMRunNewPMModulePassManager at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/PassManager.h:522
LLVMRunNewPMModulePassManager at /home/gabrielbaraldi/.julia/packages/LLVM/vIbji/lib/libLLVM_extra.jl:626 [inlined]
run! at /home/gabrielbaraldi/.julia/packages/LLVM/vIbji/src/newpm/passmanager.jl:201 [inlined]
#123 at /home/gabrielbaraldi/.julia/packages/LLVM/vIbji/src/newpm/passes.jl:716 [inlined]
macro expansion at /home/gabrielbaraldi/.julia/packages/LLVM/vIbji/src/newpm/analyses.jl:77 [inlined]
macro expansion at /home/gabrielbaraldi/.julia/packages/LLVM/vIbji/src/base.jl:98 [inlined]
analysis_managers at /home/gabrielbaraldi/.julia/packages/LLVM/vIbji/src/newpm/analyses.jl:61
run! at /home/gabrielbaraldi/.julia/packages/LLVM/vIbji/src/newpm/passes.jl:715 [inlined]
run! at /home/gabrielbaraldi/.julia/packages/LLVM/vIbji/src/newpm/passes.jl:714
...

Though to run with assertions I needed https://github.com/JuliaGPU/AMDGPU.jl/pull/545

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/ka_tests.jl:17 and reproduce the failure using a Julia build with assertions, noting that PR 545 was needed to run the tests this way. Then inspect src/llvm-late-gc-lowering.cpp around NoteDef, MaybeNoteDef, LocalScan, and runOnFunction. Done means the KA tests no longer abort on the Num >= 0 assertion.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.