Rename `Device.free` to `AMDGPU.unsafe_free!`
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 344
- Forks
- 79
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 27
Description
When allocating memory on the device with AMDGPU.malloc, it's possible to free those allocations with AMDGPU.Device.free. However, this doesn't match Julia's allocate-and-GC-later model; to that end, malloc'd data is automatically cleaned up after kernel termination anyway. It would make sense to thus rename AMDGPU.Device.free to use AMDGPU.unsafe_free! instead (which matches what the call is doing anyway, it's an unsafe operation).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by searching the repository for AMDGPU.Device.free and related references to AMDGPU.malloc. Rename the API to AMDGPU.unsafe_free! consistently, then verify that no obsolete references remain and that the existing allocation and cleanup behavior is unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100