JuliaDiff / JuliaDiff/ForwardDiff.jl
Some arithmetic functions fail after adding tags
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 1k
- Forks
- 160
- PR merge metrics
- No merged PRs in 30d
Description
#274 fixed an issue with muladd which only came up with tags were in play. The fix included adding a non-Void tag to every dual in the tests. In doing so it found 4 other instances where tests failed, though it actually boils down to two groups: division and hypot
https://github.com/ChrisRackauckas/ForwardDiff.jl/blob/patch-1/test/DualTest.jl#L361
https://github.com/ChrisRackauckas/ForwardDiff.jl/blob/patch-1/test/DualTest.jl#L447
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in test/DualTest.jl at the referenced lines around the division and hypot cases, and inspect how the non-Void tags are applied to the Dual values. Reproduce the failures and trace the affected arithmetic functions; done means the division and hypot tests pass with tagged Duals.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100