JuliaDiff / JuliaDiff/ForwardDiff.jl

Replace generated functions in Partials code with new NTuple generators

Open
#186 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
1k
Forks
160
PR merge metrics
No merged PRs in 30d

Description

Now that https://github.com/JuliaLang/julia/pull/15516 has landed, we should be able to get rid of the generated functions in the Partials code (at least on v0.6 and beyond).

We'll have to make sure that SIMD optimizations still occur, but it should be fine if the new NTuple generators are unrolling the code at compile time.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Partials code and the generated functions it uses, then review Julia PR 15516 and the new NTuple generators. Confirm that replacing the generated functions preserves SIMD optimization; the work is done when the Partials implementation no longer depends on those generated functions and its existing behavior and optimization remain intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.