JuliaDiff / JuliaDiff/ChainRulesTestUtils.jl
Change default tolerances for testers based on eltype
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 50
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
The default tolerance of atol=1e-9, rtol=1e-9 for the isapprox tests seem like they might be too stringent for 32-bit checks. Perhaps we should have a utility method for settings these tolerances based on the float eltype of the inputs?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the isapprox tests and their current atol=1e-9 and rtol=1e-9 defaults. Compare expected behavior for 32-bit and other float eltypes; the work is done when a utility selects suitable tolerances from the inputs' float eltype and the affected tests cover those cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100