JuliaDiff / JuliaDiff/ChainRulesTestUtils.jl
check_equal(::NamedTuple, ::NamedTuple) doesn't check names
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 50
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
e.g.
julia> check_equal((;a=2, b=2), (;a=2,c=2))
Test Passed
This is because it hits the general iterator fallback.
This isn't super high priority, since it only comes up in chaecking add!! behavour
(as neither value is a AbstractTangent subtype).
Still would be nice to fix.
Need to channel it towards one of our overloads for structured types
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the check_equal overloads for structured types and compare them with the general iterator fallback. Reproduce the NamedTuple example from the issue, then verify that differing field names no longer pass while matching names and values still do.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100