JuliaDiff / JuliaDiff/ChainRulesCore.jl
Removing / with tangent denominator
Open
Nobody has claimed this yet.
breaking
- Dominant language
- Julia
- Stars
- 267
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
along the same lines as #643
We should not have e.g.
Base.:(/)(a, b::AbstractThunk) = a / unthunk(b)
Base.:(/)(a::AbstractThunk, b::AbstractThunk) = unthunk(a) / unthunk(b)
We have a few of these
Since while it makes sense to divide a tangent by a scalar (its just scaling down) it does done make sense to divide a scalar by a tangent.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the division overloads shown in the issue and compare the related changes in #643. Identify the other AbstractThunk division methods, preserve tangent-by-scalar scaling, and remove the scalar-by-tangent behavior described here; add or update tests to confirm the intended division cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100