JuliaDiff / JuliaDiff/ChainRulesCore.jl

Ambiguities with Base

Open
#448 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
Julia
Stars
267
Forks
66
No merged PRs in 30d

Description

julia> Test.detect_ambiguities(ChainRulesCore, Base)
16-element Vector{Tuple{Method, Method}}:
 (*(s, comp::Tangent) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differential_arithmetic.jl:168, *(comp::Tangent, s) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differential_arithmetic.jl:169)
 (==(a, b::AbstractThunk) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:27, ==(::Missing, ::Any) in Base at missing.jl:75)
 (-(a::AbstractThunk, b) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:30, -(a, b::AbstractThunk) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:31)
 (/(z::AbstractZero, ::Any) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/abstract_zero.jl:25, /(a, b::AbstractThunk) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:33)
 (ger!(alpha, x::AbstractThunk, y, A) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:100, ger!(alpha, x, y::AbstractThunk, A) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:103)
 (/(::Any, x::ChainRulesCore.NotImplemented) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/notimplemented.jl:43, /(a::AbstractThunk, b) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:32)
 ((::ProjectTo{T, D} where D<:NamedTuple)(dx::AbstractZero) where T in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/projection.jl:127, (::ProjectTo{NoTangent, D} where D<:NamedTuple)(dx) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/projection.jl:135)
 (==(a::AbstractThunk, b) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:26, ==(::Any, ::Missing) in Base at missing.jl:76)
 (/(z::AbstractZero, ::Any) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/abstract_zero.jl:25, /(::Any, x::ChainRulesCore.NotImplemented) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/notimplemented.jl:43)
 (==(a, b::AbstractThunk) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:27, ==(w::WeakRef, v) in Base at gcutils.jl:4)
 (==(a::AbstractThunk, b) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:26, ==(w, v::WeakRef) in Base at gcutils.jl:5)
 (/(a::AbstractThunk, b) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:32, /(a, b::AbstractThunk) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:33)
 ((::ProjectTo{T, D} where D<:NamedTuple)(dx::ChainRulesCore.NotImplemented) where T in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/projection.jl:128, (::ProjectTo{NoTangent, D} where D<:NamedTuple)(dx) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/projection.jl:135)
 ((project::ProjectTo{T, D} where D<:NamedTuple)(dx::Tangent) where T in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/projection.jl:75, (::ProjectTo{NoTangent, D} where D<:NamedTuple)(dx) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/projection.jl:135)
 (/(x::ChainRulesCore.NotImplemented, ::Any) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/notimplemented.jl:42, /(a, b::AbstractThunk) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/differentials/thunks.jl:33)
 ((project::ProjectTo)(dx::Thunk) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/projection.jl:131, (::ProjectTo{NoTangent, D} where D<:NamedTuple)(dx) in ChainRulesCore at /home/jishnu/.julia/packages/ChainRulesCore/Voykb/src/projection.jl:135)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report with Test.detect_ambiguities(ChainRulesCore, Base), then inspect the listed definitions in differential_arithmetic.jl, differentials/thunks.jl, differentials/abstract_zero.jl, differentials/notimplemented.jl, and projection.jl. Determine which of the 16 method pairs require action; done means the reported ambiguities have an agreed resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.