JuliaDiff / JuliaDiff/ChainRulesCore.jl
5-arg mul! for all AbstractTangents
Open
Nobody has claimed this yet.
LinearOperators
- Dominant language
- Julia
- Stars
- 267
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
We should define 5 arg mul! for all the abstract tangents.
It can use the same logic we already have in the differential_arithmatic file.
We can for AbstractZeroTangents optimize this e.g.
LinearAlgebra.mul!(C, ::AbstractZeroTangent, ::Any, ::Any, b) = C *=b
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing logic in the differential_arithmatic file and locating the AbstractTangents definitions and current mul! methods. Implement the 5-argument form for all abstract tangents, including the suggested AbstractZeroTangent optimization, and verify that each tangent type is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100