JuliaDiff / JuliaDiff/ChainRulesCore.jl
Overload `add!!(::AbstractArray, iterator)`?
Open
Nobody has claimed this yet.
design
inplace accumulation
- Dominant language
- Julia
- Stars
- 267
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
Right now we don't overload for add!! for second argument being an iterator.
We could.
It would mean trusting broadcasting to work it out.
Rather than requiring that things are actually same shape to inplace accumulate
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing add!! methods and their tests, then trace how array and iterator arguments are currently handled. Determine the intended broadcasting and shape behavior for an iterator overload, and define tests showing that the accepted inputs accumulate correctly in place.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100