JuliaDiff / JuliaDiff/ChainRulesCore.jl

Extend scalar_rule to handle broadcast

Open
#271 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

rule definition helper speculative
Dominant language
Julia
Stars
267
Forks
66
PR merge metrics
No merged PRs in 30d

Description

As a follow up to https://github.com/FluxML/NNlib.jl/pull/257 and https://github.com/FluxML/NNlib.jl/pull/258,
I wish the @scalar_rule macro could be extended with an optional keyword argument so that it also defines
the broadcasted version of a rule, so something like

@scalar_rule  tanh(x)  1 - Ω^2    broadcast=true

I would have attempted a PR, but I quickly realized that this above my very very little macro expertise :(

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked pull requests and the @scalar_rule macro implementation. Determine how an optional broadcast=true argument should define the broadcasted rule, and verify that the example @scalar_rule tanh(x) 1 - Ω^2 broadcast=true is accepted and produces the intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend-api-design
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.