JuliaDiff / JuliaDiff/ChainRulesCore.jl

getindex on Composites doesn't alway return Zero() for not found

Open
#238 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Structural Tangent
Dominant language
Julia
Stars
267
Forks
66
PR merge metrics
No merged PRs in 30d

Description

julia> c = Composite{Any}()
Composite{Any}NamedTuple()

julia> c[:a]
ERROR: type NamedTuple has no field a

julia> c[1]
ERROR: BoundsError: attempt to access NamedTuple{(),Tuple{}}
  at index [1]

getproperty works right though:

julia> c.a
Zero()

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the empty Composite examples in the Julia REPL, then trace the getindex and getproperty behavior for missing fields and indexes. Done means missing getindex accesses return Zero() consistently with getproperty, with regression coverage for the shown cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.