JuliaDiff / JuliaDiff/ChainRulesCore.jl
Defined dot on Composite
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 267
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
Follow up to https://github.com/JuliaDiff/ChainRulesCore.jl/pull/201
Dot its defined recursively, (like adjoint and transpose).
julia> using LinearAlgebra
julia> x = [1, 10];
julia> y = [x, x]
2-element Vector{Vector{Int64}}:
[1, 10]
[1, 10]
julia> dot(y,y)
202
It that should have a natural defintion for Composites, even for Composites of Composites.
It seems like a thing that is generally defined on vector spaces.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #201 and the existing Composite behavior, then compare how dot, adjoint, and transpose are defined recursively. Verify the intended behavior with nested Composites, including the shown nested-vector example, and add coverage demonstrating that dot works at each nesting level.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100