JuliaDiff / JuliaDiff/ChainRules.jl
Move Base functions out of `/LinearAlgebra/dense.jl`
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 475
- Forks
- 98
- PR merge metrics
- No merged PRs in 30d
Description
Most of the functions in
https://github.com/JuliaDiff/ChainRules.jl/blob/master/src/rulesets/LinearAlgebra/dense.jl
right now
don't belong there.
As they are loaded even if LinearAlgebra isn't.
Now right now we don't have a Requires.jl block around that,
so it doesn't matter,
but conceptually we could.
Also it is suprising to have to go look for them there.
I know it has caught people out before.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing src/rulesets/LinearAlgebra/dense.jl and inventorying the functions currently defined there. Trace how that file is loaded when LinearAlgebra is absent, then identify an appropriate organization for the functions. Done means the misplaced Base functions have moved out of dense.jl without breaking their availability or loading behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100