JuliaDiff / JuliaDiff/ChainRules.jl
Replace withsomezeros_rewrap with ProjectTo
Open
Nobody has claimed this yet.
refactoring
- Dominant language
- Julia
- Stars
- 475
- Forks
- 98
- PR merge metrics
- No merged PRs in 30d
Description
code in a few places e.g. norm.jl uses a helper function called withsomezeros that handles making Triangular and Diagonal (etc) matrixes back into the correct types.
This seems very similar to ProjectTo and we could likely replace it with that
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with norm.jl and locate the withsomezeros helper and its other uses. Compare its behavior with ProjectTo, then determine whether the relevant uses can be replaced while preserving Triangular, Diagonal, and related matrix types; done means the replacements work without changing those results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100