Support L, U and factors properties in Cholesky

Open

#640 opened on Jun 28, 2022 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language: Julia
Stars: 475
Forks: 98
PR merge metrics: No merged PRs in 30d

Description

In relation to other comments here and here I think we should re-add support for getproperty(::Tangent{<:Cholesky}, ...) with :U or :L along with :factors. This would make release 1.35.3 slightly less breaking.

https://github.com/invenia/Nabla.jl/pull/217/files#diff-a51816a450e57348c1c90d807b0a793092bb7e368d759102888820eb2e0ee025R55

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Start with getproperty(::Tangent{<:Cholesky}, ...) and review the linked issue #216, pull request #217, and referenced diff. Confirm the expected handling for :U, :L, and :factors; done means those properties are supported without breaking the existing Cholesky tangent behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack: julia
Domain: tooling
Issue type: Feature
Difficulty: 3/5
Estimated time: 1-2 days
Activity status: Stale
Clarity: Clearly specified
Newbie friendliness: 35/100

A short digest of beginner-friendly GitHub issues.