JuliaDiff / JuliaDiff/ChainRules.jl
`sortslices` only accepts `dims::Integer`
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 475
- Forks
- 98
- PR merge metrics
- No merged PRs in 30d
Description
The original function is more flexible:
julia> sortslices(rand(2,2,2); dims=(1,2));
julia> rrule(sortslices, rand(2,2,2); dims=(1,2));
ERROR: TypeError: in keyword argument dims, expected Integer, got a value of type Tuple{Int64, Int64}
Stacktrace:
[1] top-level scope
@ REPL[21]:1
Probably easy to widen the rule, needs some care, and tests.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the ChainRules rule for sortslices and its existing tests, then inspect how the dims keyword is typed and handled. Add coverage for tuple-valued dimensions and confirm that the rule accepts the same forms as the original function.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100