JuliaDiff / JuliaDiff/ChainRules.jl

Use CommutativeMulNumber everywhere it is needed (and no where it isn't)

Open
#504 0 comments 3 reactions 1 assignee View on GitHub

@sethaxen is already working on this.

Since Aug 18, 2021.

Dominant language
Julia
Stars
475
Forks
98
No merged PRs in 30d

Description

Currently, rules for * are constrained to CommutativeMulNumber types. This is unnecessary, because only two numbers at a time are multiplied, so commutation is never needed. These constraints should be relaxed.

Conversely, the scalar rule for ^ requires commutativity but makes no such type constraint. It should be limited to CommutativeMulNumber.

There may be other cases.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.