JuliaDiff / JuliaDiff/ChainRules.jl

tests for rrule(prod, ::Symmetric) are disabled because they fail

Open
#475 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

testing
Dominant language
Julia
Stars
475
Forks
98
PR merge metrics
No merged PRs in 30d

Description

This was introduced with @test_skip in https://github.com/JuliaDiff/ChainRules.jl/pull/335
I think maybe we just forgot to debug and fix it.
Not sure why it fails, could be a problem with ChainRulesTestUtils/FiniteDifferences.jl
(I suspect in particular it maybe be that FiniteDifferences is bad at structured matrixes)

But so we don't complete lose track, i have openned this issue

https://github.com/JuliaDiff/ChainRules.jl/blob/4ad975826ea0639ad709aeb36cc5051b6bf82eaa/test/rulesets/Base/mapreduce.jl#L103-L104

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at test/rulesets/Base/mapreduce.jl lines 103–104, where the rrule(prod, ::Symmetric) tests are disabled with @test_skip. Run or inspect the skipped tests and investigate whether the failure is in ChainRulesTestUtils or FiniteDifferences, particularly for structured matrices. Done means the underlying problem is fixed and the tests can be re-enabled successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.