JuliaDiff / JuliaDiff/ChainRules.jl
Check correctness of mod and rem
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 475
- Forks
- 98
- PR merge metrics
- No merged PRs in 30d
Description
We still use a explict seed for testing mod and rem.
During #185 I removed it and those tests failed.
I have not investigated closely, it could be they are doing bad things with the domain.
If so rather than random numbers we should hard-code sensible points.
We do that in a lot of other tests.
I think I in general like that, sensible arbitary numbers rather than seeded random numbers.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the existing tests for mod and rem, especially the cases that depend on an explicit seed, and compare them with other tests using sensible hard-coded points. Determine why removing the seed causes failures and consider whether fixed domain-appropriate values make the tests reliable. Done means the tests pass without the explicit seed while still checking correct behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100