JuliaDiff / JuliaDiff/ChainRules.jl
Are the Factorization rules correct for Complex inputs?
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 475
- Forks
- 98
- PR merge metrics
- No merged PRs in 30d
Description
I see in https://github.com/JuliaDiff/ChainRules.jl/blob/master/src/rulesets/LinearAlgebra/factorization.jl
we use a fair bit of A' which is adjoint.
In other places @simeonschaub has said we need to not use that, and to use transpose instread,
so we don't recursively conjugate the complex numbers
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/rulesets/LinearAlgebra/factorization.jl, focusing on uses of A' in the factorization rules. Check the behavior for Complex inputs and compare adjoint with transpose, then verify whether the rules avoid recursive conjugation. Done means the rules' correctness for complex factorization inputs is established and any needed changes are covered by verification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100