JuliaDiff / JuliaDiff/AbstractDifferentiation.jl
Type of cotangent is sometimes not a vector in FiniteDifferences vjp tests
Open
Nobody has claimed this yet.
bug
- Dominant language
- Julia
- Stars
- 138
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
This issue came up in #47. There is one line in the tests where I pass test_types = false because one of the tests fails. FiniteDifferences seems to be spitting out a 1 column matrix instead of a vector.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the FiniteDifferences vjp tests and the line that sets test_types = false; reproduce the failing test and inspect the returned cotangent shape. Done means the cotangent is a vector rather than a one-column matrix and the type checks can run without disabling them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100